fix: fix index store panic error (#2776) (#2778)

Signed-off-by: yisaer <[email protected]>
lf-edge · Apr 17, 2024 · 687b1a0 · 687b1a0
1 parent a381e86
commit 687b1a0
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 6 deletions.
diff --git a/extensions/sqldatabase/sqlgen/sqlServerDialect_test.go b/extensions/sqldatabase/sqlgen/sqlServerDialect_test.go
@@ -202,6 +202,14 @@ func TestGenerateSQLWithMultiIndex(t *testing.T) {
 			},
 			sql: `select * from t where col2 > '2' AND col1 > '1' order by 'col2' ASC, 'col1' ASC limit 3`,
 		},
+		{
+			cfg: &InternalSqlQueryCfg{
+				Table: "t",
+				Limit: 3,
+				store: store.NewIndexFieldWrap(),
+			},
+			sql: `select * from t  limit 3`,
+		},
 	}
 
 	for _, tc := range testcases {

diff --git a/extensions/sqldatabase/sqlgen/sqlgen.go b/extensions/sqldatabase/sqlgen/sqlgen.go
@@ -58,9 +58,7 @@ func (i *InternalSqlQueryCfg) InitIndexFieldStore() {
 		i.store.Init(f)
 		return
 	}
-	if len(i.IndexFields) > 0 {
-		i.store.Init(i.IndexFields...)
-	}
+	i.store.Init(i.IndexFields...)
 }
 
 func (i *InternalSqlQueryCfg) SetIndexValue(v interface{}) {

diff --git a/extensions/sqldatabase/sqlgen/templateSqlDialect.go b/extensions/sqldatabase/sqlgen/templateSqlDialect.go
@@ -114,9 +114,7 @@ func (t *TemplateSqlQueryCfg) InitIndexFieldStore() {
 		t.store.Init(f)
 		return
 	}
-	if len(t.IndexFields) > 0 {
-		t.store.Init(t.IndexFields...)
-	}
+	t.store.Init(t.IndexFields...)
 }
 
 func (t *TemplateSqlQueryCfg) SetIndexValue(v interface{}) {

diff --git a/extensions/sqldatabase/sqlgen/templateSqlDialect_test.go b/extensions/sqldatabase/sqlgen/templateSqlDialect_test.go
@@ -220,6 +220,13 @@ func TestGenerateTemplateWithMultiIndex(t *testing.T) {
 			},
 			sql: "select * from table where col1 > `1` AND col2 > `2` order by co1 ASC, co2 ASC",
 		},
+		{
+			cfg: &TemplateSqlQueryCfg{
+				TemplateSql: "select * from table",
+				store:       store.NewIndexFieldWrap(),
+			},
+			sql: "select * from table",
+		},
 	}
 
 	for _, tc := range testcases {