Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] modify pod app link support #545

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

giggsoff
Copy link
Collaborator

@giggsoff giggsoff commented Mar 2, 2021

The ability to modify link of existing pod.

Signed-off-by: Petr Fedchenkov [email protected]

Copy link
Contributor

@rvs rvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giggsoff giggsoff force-pushed the modify-app-link branch 2 times, most recently from febdfee to abaeb5f Compare March 4, 2021 09:58
@giggsoff giggsoff changed the title modify pod app link support [WIP] modify pod app link support Mar 4, 2021
Signed-off-by: Petr Fedchenkov <[email protected]>
Copy link
Contributor

@rvs rvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious -- what is left here to do @giggsoff ? When do you think we can merge this?

@giggsoff
Copy link
Collaborator Author

Actually, I'm currently trying to figure out how this relates to processes in zedcloud. It’s not clear to me yet.

@rvs
Copy link
Contributor

rvs commented Mar 30, 2021

Actually, I'm currently trying to figure out how this relates to processes in zedcloud. It’s not clear to me yet.

Can you please elaborate so I may be able to assist you?

@giggsoff
Copy link
Collaborator Author

Actually, I'm currently trying to figure out how this relates to processes in zedcloud. It’s not clear to me yet.

Can you please elaborate so I may be able to assist you?

Well, we can do update with different actions:

  1. Change UUID of volume and image
  2. Change generation count of volume
  3. Change only links of volume and image

At the same time we can keep old volumes or delete them immediately (if I correctly understood, zedcloud keep them, check new ones applied, then delete).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants