GitHub Actions use org secrets #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Avi Deitcher <[email protected]>
yash-zededa
approved these changes
Jul 10, 2024
milan-zededa
approved these changes
Jul 10, 2024
|
Maybe we should use never version of the docker-login action to avoid the warning and problems in the future: https://github.com/lf-edge/adam/actions/runs/9871707714/job/27260199006#step:5:10 |
|
Yes, we definitely should. This PR was very focused, fix that one thing. Another PR for that would be good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lfedge created a new user for all of the workflows, and saved the credentials as org secrets, specifically
RELEASE_DOCKERHUB_ACCOUNTandRELEASE_DOCKERHUB_TOKEN. This PR removes the different name in the flows and uses the org standardsecrets.RELEASE_DOCKERHUB_ACCOUNTandsecrets.RELEASE_DOCKERHUB_TOKEN.