when keys not found in redis, return NotFoundError #126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file and memory driver distinguish between actual errors and things that are not found by returning a
common.NotFoundError
, which the admin handler check for.The redis driver does not; for everything that it fails to get, it just returns an error.
The net result, e.g, is if you look up a certificate for a device that does not exist, with the memory or file driver, adam will return a 404, while the redis driver will return a 400, which is incorrect. Downstream things like eden then think it is an error, rather than something just not found yet.
This adds
NotFoundError
to places in redis whereHGet
and its variants returnredis.Nil
, which means, "I could not find the key."