Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump google.golang.org/protobuf from 1.28.1 to 1.33.0 #124

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 13, 2024

Bumps google.golang.org/protobuf from 1.28.1 to 1.33.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Mar 13, 2024
@eriknordmark
Copy link
Contributor

@dependabot rebase

Bumps google.golang.org/protobuf from 1.28.1 to 1.33.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/google.golang.org/protobuf-1.33.0 branch from 75ce205 to 60a02da Compare May 28, 2024 14:34
@eriknordmark
Copy link
Contributor

@deitch @giggsoff this PR results in some off build failures which I don't see if I clone the PR branch and build on my laptop:
Error: pkg/driver/common/common.go:19:2: //go:build comment without // +build comment
Error: ../../../go/pkg/mod/google.golang.org/[email protected]/internal/impl/api_export.go:12:2: //go:build comment without // +build comment
Error: ../../../go/pkg/mod/google.golang.org/[email protected]/internal/filedesc/desc_lazy.go:15:2: //go:build comment without // +build comment
Error: Process completed with exit code 1.

I don't know if this is also a golang version issue??

@giggsoff giggsoff force-pushed the dependabot/go_modules/google.golang.org/protobuf-1.33.0 branch from 584f41e to ca7a7ab Compare May 30, 2024 06:38
giggsoff
giggsoff previously approved these changes May 30, 2024
Copy link
Collaborator

@giggsoff giggsoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a problem with go version. Aligned with Eden versions.

@giggsoff giggsoff force-pushed the dependabot/go_modules/google.golang.org/protobuf-1.33.0 branch from ca7a7ab to a16d005 Compare May 30, 2024 07:05
@eriknordmark eriknordmark merged commit 6684794 into master Jun 24, 2024
2 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/google.golang.org/protobuf-1.33.0 branch June 24, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants