Small script fixes (Make which truly silent and make start_lexical.sh symbolic-link friendly) #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubin55
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, you actually have to be in the directory that contains
bin/start_lexical.shor run the script with an absolute (full) path. Whilst packaging this for Arch Linux I ran into the issue that the script cannot be simply linked to (sinceBASH_SOURCE[0]will then resolve as /usr/bin instead).This PR makes it so that the script will also work when soft-linked to (using
ln -s- the script usesreadlinkto find the real path of the script).Additionally, this PR silences the two which statements (on some (all?) platforms, like Arch Linux, the output of which when a command is not found, goes to
stderr).