Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to updated codecov action #6

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Switch to updated codecov action #6

merged 2 commits into from
Apr 16, 2024

Conversation

znicholls
Copy link
Collaborator

@znicholls znicholls commented Apr 12, 2024

Description

Checklist

Please confirm that this pull request has done the following:

- [ ] Tests added
- [ ] Documentation added (where applicable)

  • Changelog item added to changelog/

@znicholls
Copy link
Collaborator Author

@lewisjared if you make me an admin of this repo I can add the token. Alternately you can follow the docs here https://docs.codecov.com/docs/github-2-getting-a-codecov-account-and-uploading-coverage and add the code cov token secret then the code cov integration should work

@znicholls znicholls marked this pull request as draft April 12, 2024 05:51
@znicholls znicholls requested a review from lewisjared April 12, 2024 05:51
@lewisjared
Copy link
Owner

Thanks. I need my Yubikey to do that so I'll set that up once I'm home

@znichollscr
Copy link

@lewisjared ping here

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Owner

@lewisjared lewisjared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I added the secret as I couldn't figure out how to make you an admin.

@znicholls znicholls marked this pull request as ready for review April 16, 2024 23:51
@znicholls znicholls merged commit ea7eab7 into main Apr 16, 2024
10 checks passed
@znicholls znicholls deleted the update-codecov branch April 16, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants