Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up from #3 #4

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Clean up from #3 #4

merged 2 commits into from
Apr 11, 2024

Conversation

lewisjared
Copy link
Owner

Description

General cleanup from @znicholls suggestions in #3. The pipeline is now (tentatively) working

Checklist

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Changelog item added to changelog/

@lewisjared lewisjared merged commit 047f32b into main Apr 11, 2024
10 checks passed
@lewisjared lewisjared deleted the final-release branch April 11, 2024 05:43
@lewisjared
Copy link
Owner Author

Interesting things learnt along the way:

  • Need to remember that there are two versions in the pyproject.toml (poetry + PEP621). Using sed to update both instead of poetry version
  • I learnt how to reuse a workflow (the release workflow using the wheels workflow)
  • Hard to get feedback in a reasonable time period
  • qemu arch emulation (linux) is 10x slower than native. Looking forward to the GA of arm-based linux runners - alternatively could build on Mac

@znicholls
Copy link
Collaborator

  • I learnt how to reuse a workflow (the release workflow using the wheels workflow)

Nice trick

  • Hard to get feedback in a reasonable time period

Just cause CI is slow?

  • qemu arch emulation (linux) is 10x slower than native

Can we build without emulation for now (we don't have many linux users yet anyway...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants