Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for refined library #34

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Support for refined library #34

merged 1 commit into from
Jan 2, 2024

Conversation

danslapman
Copy link
Member

This PR adds support for refined types

Copy link
Contributor

@desavitsky desavitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add some tests?

@desavitsky
Copy link
Contributor

I think that adding support for iron might also be great

@danslapman danslapman force-pushed the feature/refined-support branch 2 times, most recently from 7707620 to 2d7014c Compare January 2, 2024 17:10
@danslapman danslapman force-pushed the feature/refined-support branch from 2d7014c to b3d9ce1 Compare January 2, 2024 17:41
@danslapman danslapman added the enhancement New feature or request label Jan 2, 2024
@danslapman danslapman merged commit 3bdbcb0 into main Jan 2, 2024
5 checks passed
@danslapman danslapman deleted the feature/refined-support branch January 2, 2024 17:47

class RoundRobinSpec extends AnyFunSuite with Matchers with TryValues with EitherValues {
test("Refined serialization") {
val refinedVal: Int Refined Positive = refineV[Positive](5).value
Copy link
Contributor

@desavitsky desavitsky Jan 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

val refinedVal: Int Refined Positive = 5

Can't we write like that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This refined's macro is not yet re-written for Scala 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants