Skip to content

Commit

Permalink
fuse: add missing FR_FORCE
Browse files Browse the repository at this point in the history
commit 2e38bea99a80eab408adee27f873a188d57b76cb upstream.

fuse_file_put() was missing the "force" flag for the RELEASE request when
sending synchronously (fuseblk).

If this flag is not set, then a sync request may be interrupted before it
is dequeued by the userspace filesystem.  In this case the OPEN won't be
balanced with a RELEASE.

[js] force is a variable, not a bit

Signed-off-by: Miklos Szeredi <[email protected]>
Fixes: 5a18ec1 ("fuse: fix hang of single threaded fuseblk filesystem")
Signed-off-by: Jiri Slaby <[email protected]>
Signed-off-by: Willy Tarreau <[email protected]>
  • Loading branch information
Miklos Szeredi authored and wtarreau committed Jun 7, 2017
1 parent f90660e commit 5beea85
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions fs/fuse/file.c
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ static void fuse_file_put(struct fuse_file *ff, bool sync)
struct fuse_req *req = ff->reserved_req;

if (sync) {
req->force = 1;
req->background = 0;
fuse_request_send(ff->fc, req);
path_put(&req->misc.release.path);
Expand Down

0 comments on commit 5beea85

Please sign in to comment.