fix: Fix updating tools #1886
Merged
fix: Fix updating tools #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, adding tools in the dev portal causes all the existing tools to be removed, making the tools unusable. This is due to a bug, as adding tools is currently done by invoking
update_agentwith alistof the desired tool name, which completely replaces the entire tool list, instead of appending.This PR introduces two new API endpoints:
add_tools_to_agent: appends a list of tools to the existing tools for an agentremove_tools_from_agent: removes a list of tools from the existing tools for an agentWe fix a variety of bugs with the tools, for example, where descriptions are not being properly set on update.
Testing
We write a comprehensive unit test that adds two tools step by step, confirms that both are in, and selectively removes one of the tools.