Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve I2C, fix flash reading overflow and refactoring #3

Merged
merged 10 commits into from
Aug 29, 2024

Conversation

jnthbdn
Copy link
Collaborator

@jnthbdn jnthbdn commented Jul 2, 2024

No description provided.

@jnthbdn jnthbdn requested a review from nedseb July 2, 2024 13:56
Copy link

@nedseb nedseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comme la précédente, le nom n'est pas informatif.
Je te laisse voir pour la merger en fonction de ce que tu juges utile de modifier après mes commentaires (je ne suis pas fan des fichiers entièrement commentés et pas supprimés)

source/board/steami/steami32.c Outdated Show resolved Hide resolved
source/board/steami/steami_tim.c Outdated Show resolved Hide resolved
source/board/steami/steami_tim.h Outdated Show resolved Hide resolved
@jnthbdn
Copy link
Collaborator Author

jnthbdn commented Aug 29, 2024

Comme la précédente, le nom n'est pas informatif. Je te laisse voir pour la merger en fonction de ce que tu juges utile de modifier après mes commentaires (je ne suis pas fan des fichiers entièrement commentés et pas supprimés)

En effet pas très informatifs, mais il n'y a pas grand chose de nouveau, c'est surtout du refactor de code et la correction de "bugs" (qui n'en sont pas encore ^^).

@jnthbdn jnthbdn changed the title Bugs and features Improve I2C, fix flash reading overflow and refactoring Aug 29, 2024
@jnthbdn jnthbdn merged commit 1a357b2 into develop Aug 29, 2024
1 check passed
@jnthbdn jnthbdn deleted the bugs_and_features branch August 29, 2024 10:33
@jnthbdn jnthbdn restored the bugs_and_features branch October 10, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants