Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: No longer accumulate orphans on each test run #7978

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Conversation

beautifulentropy
Copy link
Member

@beautifulentropy beautifulentropy commented Jan 24, 2025

Stop producing orphans and No such container: boulder_tests on each test invocation.


Note

No more:
$ ./tn.sh -uvw
WARN[0000] Found orphan containers ([boulder-bsetup-run-e1f829a31082 boulder-boulder-run-46a3dfe373bc boulder-bsetup-run-12fff21f4cf3 boulder-boulder-run-f42253a0e5d4 boulder-bsetup-run-2e3aa384e16f boulder-boulder-run-f099848f9d4c boulder-bsetup-run-c34f6931196c boulder-boulder-run-e10238f0f513 boulder-bsetup-run-3eca5f83e3c5 boulder-boulder-run-336e028210ce boulder-bsetup-run-56c85a9e03ea boulder-boulder-run-29c7ee095d16 boulder-bsetup-run-635603efffa9 boulder-boulder-run-9f5a859edb4d boulder-bsetup-run-4c0f6774b9a4 boulder-boulder-run-97f7575db781 boulder-bsetup-run-79735134cda5 boulder-boulder-run-3a8d5cb917bb boulder-bsetup-run-00537abe7e00 boulder-boulder-run-05af85f0bb6e boulder-bsetup-run-d1604e7c822e boulder-boulder-run-8bac2b5d6c53 boulder-bsetup-run-fb7f2eabb6c1 boulder-boulder-run-2063c1e2969e boulder-bsetup-run-5046ab5ad729 boulder-boulder-run-467e9767fb35 boulder-bsetup-run-ba53209a3782 boulder-boulder-run-5750eb012e2c boulder-bsetup-run-33cb73238481 boulder-boulder-run-2f8d9671cc8b boulder-bsetup-run-1f6839a8fd41 boulder-boulder-run-7696bfe0e112 boulder-bsetup-run-8ec3b7363ec6 boulder-boulder-run-e2d122934054 boulder-bsetup-run-e9e1d9d6ae44 boulder-boulder-run-ca980bf12c5c boulder-bsetup-run-b0fa4882ced3 boulder-boulder-run-0ac6ffaec102 boulder-bsetup-run-f6fd7403be5e boulder-boulder-run-cdb1e7ed894a boulder-bsetup-run-4a12c3313d50 boulder-boulder-run-2d20da0716c8 boulder-bsetup-run-cfd64f05e4a2 boulder-boulder-run-a4ebe93e405d boulder-bsetup-run-2d240b943535 boulder-boulder-run-360147415f74 boulder-bsetup-run-7c119400e195 boulder-boulder-run-50e428e3f5f1 boulder-bsetup-run-bd4f0c8b28f3 boulder-boulder-run-63e195f82802 boulder-bsetup-run-ee6ef6ac98f0]) for this project. If you removed or renamed this service in your compose file, you can run this command with the --remove-orphans flag to clean it up.

@beautifulentropy beautifulentropy requested a review from a team as a code owner January 24, 2025 19:03
@beautifulentropy beautifulentropy changed the title test: No longer accumlate orphans for each test run test: No longer accumlate orphans on each test run Jan 24, 2025
@jsha
Copy link
Contributor

jsha commented Jan 24, 2025

Ooh, thanks for addressing this, this is great. That orphaned containers message has been bugging me too.

One thing I'm confused about: We pass --name boulder_tests, so why do we generate orphans named like boulder-boulder-run-46a3dfe373bc? It seems like that should only ever create one container, named boulder_tests. bsetup of course is different; I see that it doesn't specify --name, so it makes sense that it creates a randomly named container each time.

@jsha
Copy link
Contributor

jsha commented Jan 24, 2025

Did a little local testing: ./t.sh -i for me does generate a single orphan named boulder_tests. Probably the boulder-run-46a3dfe373bc orphans that you and I both have are the result of manual runs like docker compose run boulder go generate ./....

So this all looks great to me. 🎉

tn.sh Outdated Show resolved Hide resolved
@beautifulentropy beautifulentropy requested a review from jsha January 24, 2025 19:35
@jsha jsha changed the title test: No longer accumlate orphans on each test run test: No longer accumulate orphans on each test run Jan 24, 2025
@jsha jsha merged commit 8ab022e into main Jan 24, 2025
12 checks passed
@jsha jsha deleted the look-ma-no-orphans branch January 24, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants