issuance: add CRLDistributionPoints to certs #7974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jsha, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
jsha
changed the title
aarongable
reviewed
Jan 30, 2025
jprenken
previously approved these changes
Jan 30, 2025
jsha
added a commit
that referenced
this pull request
Jan 30, 2025
To achieve this without breaking hashes of deployed configs, create a ProfileConfigNew containing the new field (and removing some deprecated fields). Move the CA's profile-hashing logic into the `issuance` package, and gate it on the presence of IncludeCRLDistributionPoints. If that field is false (the default), create an instance of the old `ProfileConfig` with the appropriate values and encode/hash that instead. Note: the IncludeCRLDistributionPoints field does not yet control any behavior. That will be part of #7974. Part of #7094
The CRLDP is included only when the profile's IncludeCRLDistributionPoints field is true. Introduce a new config field for issuers, CRLShards. If this is zero and IncludeCRLDistributionPoints is true, issuance will error. The CRL shard is assigned at issuance time based on the (random) low bits of the serial number.
jprenken
approved these changes
Jan 30, 2025
aarongable
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CRLDP is included only when the profile's IncludeCRLDistributionPoints field is true.
Introduce a new config field for issuers, CRLShards. If IncludeCRLDistributionPoints is true and this is zero, issuance will error.
The CRL shard is assigned at issuance time based on the (random) low bits of the serial number.
Part of #7094.