Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration: Fix typo in TestReRevocation #7970

Merged
merged 1 commit into from
Jan 22, 2025
Merged

integration: Fix typo in TestReRevocation #7970

merged 1 commit into from
Jan 22, 2025

Conversation

beautifulentropy
Copy link
Member

Noticed this while reviewing #7957.

@beautifulentropy beautifulentropy requested a review from a team as a code owner January 22, 2025 21:22
@beautifulentropy beautifulentropy requested a review from jsha January 22, 2025 21:22
aarongable
aarongable approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mistake didn't break the test because there's only one test case with expectError: false, and it has reason2: 1, which happens to be the same value as the ocsp.Revoked constant. sigh

@jsha jsha merged commit ca73500 into main Jan 22, 2025
12 checks passed
@jsha jsha deleted the fix-rerevocation-typo branch January 22, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsha jsha jsha approved these changes

@aarongable aarongable aarongable approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beautifulentropy @jsha @aarongable