Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RA: Allow profile selection to be gated on account-based allow lists #7959

Merged
merged 12 commits into from
Jan 24, 2025
Merged

RA: Allow profile selection to be gated on account-based allow lists #7959

merged 12 commits into from
Jan 24, 2025

Conversation

beautifulentropy
Copy link
Member

@beautifulentropy beautifulentropy commented Jan 20, 2025 •
edited
Loading

Use the new allowlist package added in #7958 to implement an account-based allow list for profile selection in the RA.

Part of #7604

@beautifulentropy beautifulentropy force-pushed the profile-selection-allowlist branch 4 times, most recently from 1758de8 to 62b8206 Compare January 21, 2025 00:13
@beautifulentropy beautifulentropy force-pushed the profile-selection-allowlist branch from 62b8206 to c73237e Compare January 21, 2025 15:24
@beautifulentropy beautifulentropy marked this pull request as ready for review January 21, 2025 15:33
@beautifulentropy beautifulentropy requested a review from a team as a code owner January 21, 2025 15:33
@beautifulentropy beautifulentropy requested review from jprenken and removed request for a team January 21, 2025 15:33
Base automatically changed from generic-allow-list to main January 21, 2025 17:54
@beautifulentropy beautifulentropy marked this pull request as draft January 21, 2025 19:50
@beautifulentropy
Copy link
Member Author

beautifulentropy commented Jan 21, 2025 •
edited
Loading

As discussed offline, putting this into draft to introduce a third state (nil) that this new config field can have.

@beautifulentropy beautifulentropy marked this pull request as ready for review January 22, 2025 22:22
@beautifulentropy beautifulentropy marked this pull request as draft January 22, 2025 22:33
@beautifulentropy beautifulentropy removed the request for review from jprenken January 22, 2025 22:33
aarongable
aarongable reviewed Jan 22, 2025
View reviewed changes
allowlist/main.go Outdated Show resolved Hide resolved
cmd/boulder-ra/main.go Outdated Show resolved Hide resolved
ra/ra.go Outdated Show resolved Hide resolved
@beautifulentropy beautifulentropy marked this pull request as ready for review January 23, 2025 17:51
jprenken
jprenken previously approved these changes Jan 23, 2025
View reviewed changes
@jprenken jprenken requested a review from a team January 23, 2025 20:17
aarongable
aarongable reviewed Jan 24, 2025
View reviewed changes
cmd/boulder-ra/main.go Outdated Show resolved Hide resolved
ra/ra.go Outdated Show resolved Hide resolved
ra/ra_test.go Show resolved Hide resolved
allowlist/main_test.go Show resolved Hide resolved
@beautifulentropy beautifulentropy mentioned this pull request Jan 24, 2025
Merged
aarongable
aarongable previously approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two test nits.

ra/ra_test.go Outdated Show resolved Hide resolved
ra/ra_test.go Show resolved Hide resolved
jprenken
jprenken previously approved these changes Jan 24, 2025
View reviewed changes
@beautifulentropy beautifulentropy dismissed stale reviews from jprenken and aarongable via b370dec January 24, 2025 17:09
@beautifulentropy beautifulentropy force-pushed the profile-selection-allowlist branch from b87227f to aaf942d Compare January 24, 2025 17:10
aarongable
aarongable approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on the parallelism, I'd forgotten that the inner loop was modifying ra.validationProfiles.

@beautifulentropy beautifulentropy merged commit a78efb8 into main Jan 24, 2025
12 checks passed
@beautifulentropy beautifulentropy deleted the profile-selection-allowlist branch January 24, 2025 17:27
@aarongable aarongable mentioned this pull request Jan 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongable aarongable aarongable approved these changes

@jprenken jprenken jprenken approved these changes

@jsha jsha Awaiting requested review from jsha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beautifulentropy @aarongable @jprenken