Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: Use hex-encoding for HMACKey #7950

Merged
merged 2 commits into from
Jan 15, 2025
Merged

config: Use hex-encoding for HMACKey #7950

merged 2 commits into from
Jan 15, 2025

Conversation

beautifulentropy
Copy link
Member

No description provided.

@beautifulentropy beautifulentropy marked this pull request as ready for review January 14, 2025 22:43
@beautifulentropy beautifulentropy requested a review from a team as a code owner January 14, 2025 22:43
jprenken
jprenken previously approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@jprenken jprenken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. It looks like we're missing test coverage for HMAC keys, though, which might be nice to add.

aarongable
aarongable reviewed Jan 14, 2025
View reviewed changes
cmd/config.go Outdated Show resolved Hide resolved
@beautifulentropy beautifulentropy merged commit dfdf554 into main Jan 15, 2025
12 checks passed
@beautifulentropy beautifulentropy deleted the fix-hmac-key-size branch January 15, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongable aarongable aarongable approved these changes

@jprenken jprenken jprenken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beautifulentropy @aarongable @jprenken