Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate x509.Certificate.Policies field #7940

Merged
merged 6 commits into from
Mar 10, 2025

Conversation

Juneezee
Copy link
Contributor

@Juneezee Juneezee commented Jan 12, 2025

Part of #7148.

Note

Starting from Go 1.24, x509.Certificate.Policies is the default field used for marshalling certificates. golang/go@918765b

@Juneezee Juneezee requested a review from a team as a code owner January 12, 2025 08:24
@Juneezee Juneezee requested a review from aarongable January 12, 2025 08:24
ZLint requires the field to be set.

Signed-off-by: Eng Zer Jun <[email protected]>
@Juneezee Juneezee changed the title ceremony: Replace x509.Certificate.PolicyIdentifiers with Policies ceremony: Populate x509.Certificate.Policies field Jan 12, 2025
Copy link
Contributor Author

@Juneezee Juneezee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ZLint still requires the PolicyIdentifiers field to be populated so we cannot drop the PolicyIdentifiers field completely yet.

https://github.com/letsencrypt/boulder/actions/runs/12731876566/job/35486388841#step:6:22:

failed lint(s): e_sub_ca_certificate_policies_missing ()

I have submitted an issue zmap/zlint#910 to ZLint repository.

Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does not close #7148. In order to fully complete that ticket, it needs to also address the PolicyIdentifiers/Policies fields during issuance of Subscriber certificates, as well as anywhere else we construct an x509.Certificate. There may be other places I missed, you should search for them.

@Juneezee
Copy link
Contributor Author

Populated the Policies field in places where PolicyIdentifiers are also populated in commit 4ad9f89.

I performed a search in VSCode and found 8 occurrences of the word PolicyIdentifiers.

vscode search

@Juneezee Juneezee requested a review from aarongable January 14, 2025 01:48
Reference: #7940 (review)
Signed-off-by: Eng Zer Jun <[email protected]>
@Juneezee Juneezee requested a review from aarongable January 14, 2025 19:46
@Juneezee Juneezee changed the title ceremony: Populate x509.Certificate.Policies field Populate x509.Certificate.Policies field Jan 17, 2025
aarongable
aarongable previously approved these changes Jan 17, 2025
Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think this approach makes sense. Requesting second review from the team.

@aarongable aarongable requested a review from jsha January 17, 2025 20:31
@beautifulentropy beautifulentropy self-requested a review January 22, 2025 17:05
Copy link
Member

@beautifulentropy beautifulentropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @Juneezee! Overall I think this change looks really good, I have just few suggestions to improve it a little more.

Reference: #7940 (review)
Signed-off-by: Eng Zer Jun <[email protected]>
@beautifulentropy
Copy link
Member

Just FYI, this PR is now on-hold until we're using Go 1.24 in our go.mod. No further action is required on your end.

@beautifulentropy
Copy link
Member

With #7971 landed, we should land this after a followup PR where go1.23.x comes out of the CI versions.

@aarongable aarongable merged commit eac26b8 into letsencrypt:main Mar 10, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants