refactor: remove usages of experimental maps package #7849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All 4 usages of the `maps.Keys` function from the `golang.org/x/exp/maps` package can be refactored. If we need it again in the future, it is available in the standard library since Go 1.23 [1]. [1]: https://go.dev/doc/go1.23#iterators Signed-off-by: Eng Zer Jun <[email protected]>
aarongable
requested changes
Nov 26, 2024
Reference: #7849 (comment) Signed-off-by: Eng Zer Jun <[email protected]>
aarongable
previously approved these changes
Dec 3, 2024
jsha
requested changes
Dec 4, 2024
Reference: #7849 (review) Signed-off-by: Eng Zer Jun <[email protected]>
jsha
approved these changes
Dec 6, 2024
aarongable
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All 4 usages of the
maps.Keysfunction from thegolang.org/x/exp/mapspackage can be refactored to a simpler alternative. If we need it in the future, it is available in the standard library since Go 1.23 1.Footnotes
https://go.dev/doc/go1.23#iterators ↩