-
-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
va: compute maxRemoteFailures based on MPIC #7810
Open
jsha
wants to merge
18
commits into
main
Choose a base branch
from
va-maxremotefailures-mpic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jsha, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
You've got a CI failure:
|
Test failure is a race condition fixed in #7811. |
Previously this was a configuration field.
jsha
force-pushed
the
va-maxremotefailures-mpic
branch
from
November 14, 2024 22:18
7113f0c
to
9ca0693
Compare
The tests are now fixed. |
beautifulentropy
previously approved these changes
Nov 15, 2024
aarongable
reviewed
Nov 15, 2024
Main merged, conflicts resolved, tests passing again 🎉 |
aarongable
previously approved these changes
Nov 15, 2024
aarongable
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this was a configuration field.
Ports
maxAllowedFailures()
fromdetermineMaxAllowedFailures()
in #7794.Test updates:
Remove the
maxRemoteFailures
param fromsetup
in all VA tests.Some tests were depending on setting this param directly to provoke failures.
For example,
TestMultiVAEarlyReturn
previously relied on "zero allowed failures". Since the number of allowed failures is now 1 for the number of remote VAs we were testing (2), the VA wasn't returning early with an error; it was succeeding! To fix that, make sure there are two failures. Since two failures from two RVAs wouldn't exercise the right situation, add a third RVA, so we get two failures from three RVAs.Similarly, TestMultiCAARechecking had several test cases that omitted this field, effectively setting it to zero allowed failures. I updated the "1 RVA failure" test case to expect overall success and added a "2 RVA failures" test case to expect overall failure (we previously expected overall failure from a single RVA failing).
In TestMultiVA I had to change a test for
len(lines) != 1
tolen(lines) == 0
, because with more backends we were now logging more errors, and finding e.g.len(lines)
to be 2.