Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

va: compute maxRemoteFailures based on MPIC #7810

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

jsha
Copy link
Contributor

@jsha jsha commented Nov 14, 2024

Previously this was a configuration field.

Ports maxAllowedFailures() from determineMaxAllowedFailures() in #7794.

Test updates:

Remove the maxRemoteFailures param from setup in all VA tests.

Some tests were depending on setting this param directly to provoke failures.

For example, TestMultiVAEarlyReturn previously relied on "zero allowed failures". Since the number of allowed failures is now 1 for the number of remote VAs we were testing (2), the VA wasn't returning early with an error; it was succeeding! To fix that, make sure there are two failures. Since two failures from two RVAs wouldn't exercise the right situation, add a third RVA, so we get two failures from three RVAs.

Similarly, TestMultiCAARechecking had several test cases that omitted this field, effectively setting it to zero allowed failures. I updated the "1 RVA failure" test case to expect overall success and added a "2 RVA failures" test case to expect overall failure (we previously expected overall failure from a single RVA failing).

In TestMultiVA I had to change a test for len(lines) != 1 to len(lines) == 0, because with more backends we were now logging more errors, and finding e.g. len(lines) to be 2.

@jsha jsha requested a review from a team as a code owner November 14, 2024 20:41
Copy link
Contributor

@jsha, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values.

@beautifulentropy
Copy link
Member

beautifulentropy commented Nov 14, 2024

You've got a CI failure:

--- FAIL: TestMultiVALogging (0.00s)
    va_test.go:636: expected perspective of VA to be dev-arin

@letsencrypt letsencrypt deleted a comment from github-actions bot Nov 14, 2024
@jsha
Copy link
Contributor Author

jsha commented Nov 14, 2024

Test failure is a race condition fixed in #7811.

@jsha
Copy link
Contributor Author

jsha commented Nov 14, 2024

The tests are now fixed.

test/config/va.json Outdated Show resolved Hide resolved
va/va_test.go Outdated Show resolved Hide resolved
@jsha
Copy link
Contributor Author

jsha commented Nov 15, 2024

Main merged, conflicts resolved, tests passing again 🎉

aarongable
aarongable previously approved these changes Nov 15, 2024
va/caa_test.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants