Stop using LockCol in registrations table (#7935)

Alter the `LockCol` column to have a default value, so we can omit it from `INSERT`s. Part of #7934
letsencrypt · Jan 17, 2025 · 6f4eb5a · 6f4eb5a
1 parent dfdf554
commit 6f4eb5a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/sa/database.go b/sa/database.go
@@ -265,7 +265,6 @@ func (log *SQLLogger) Printf(format string, v ...interface{}) {
 func initTables(dbMap *borp.DbMap) {
 	regTable := dbMap.AddTableWithName(regModel{}, "registrations").SetKeys(true, "ID")
 
-	regTable.SetVersionCol("LockCol")
 	regTable.ColMap("Key").SetNotNull(true)
 	regTable.ColMap("KeySHA256").SetNotNull(true).SetUnique(true)
 	dbMap.AddTableWithName(issuedNameModel{}, "issuedNames").SetKeys(true, "ID")

diff --git a/sa/db-next/boulder_sa/20250110000000_NullRegistrationsLockCol.sql b/sa/db-next/boulder_sa/20250110000000_NullRegistrationsLockCol.sql
@@ -0,0 +1,10 @@
+
+-- +migrate Up
+-- SQL in section 'Up' is executed when this migration is applied
+
+ALTER TABLE `registrations` ALTER COLUMN `LockCol` SET DEFAULT 0;
+
+-- +migrate Down
+-- SQL section 'Down' is executed when this migration is rolled back
+
+ALTER TABLE `registrations` ALTER COLUMN `LockCol` DROP DEFAULT;