Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Maintenance #922

Merged
merged 3 commits into from
Apr 13, 2024
Merged

CI Maintenance #922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
909740c
Stop using -Weverything
lethal-guitar Apr 13, 2024
980f648
Update Google Benchmark
lethal-guitar Apr 13, 2024
a44725f
Fix Mac OS CI build
lethal-guitar Apr 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:
- name: Test (release)
run: cd build && ctest
build_osx:
runs-on: macos-11
runs-on: macos-latest
steps:
- uses: actions/checkout@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion benchmark/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ include(FetchContent)
FetchContent_Declare(
benchmark
GIT_REPOSITORY https://github.com/google/benchmark.git
GIT_TAG v1.5.3
GIT_TAG v1.8.3
)
FetchContent_GetProperties(benchmark)
if(NOT benchmark_POPULATED)
Expand Down
2 changes: 1 addition & 1 deletion benchmark/bench_string_utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ static void BMStringSplit(benchmark::State& state)
std::string const kInputString = "Hello, world";
for (auto _ : state)
{
const auto v = rigel::strings::split(kInputString, ',');
auto v = rigel::strings::split(kInputString, ',');
benchmark::DoNotOptimize(v);
benchmark::ClobberMemory();
}
Expand Down
3 changes: 2 additions & 1 deletion cmake/rigel.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ function(rigel_enable_warnings target)
endif()
elseif(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
target_compile_options(${target} PRIVATE
-Weverything
-Wall
-Wextra
-Wno-unknown-warning-option
-Wno-c++98-compat
-Wno-c++98-compat-pedantic
Expand Down
Loading