update comments to include iat #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, I didn't immediately realize the nuance in your original discussion post: I thought you were only talking about "if I'll do one round of sanity check before merging to see if this is indeed a comment problem and not an implementation problem. |
|
Right, yeah, these were just comments predating the actual code. Thanks for the fixes. |
lestrrat
pushed a commit
that referenced
this pull request
Oct 23, 2024
lestrrat
added a commit
that referenced
this pull request
Oct 23, 2024
Co-authored-by: Chris Riley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WithAcceptableSkew()andWithClock()both apply toiatas well asnbfandexp- update comments to reflect that.