-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue 4313 selector list not expanding #4314
base: master
Are you sure you want to change the base?
Conversation
* Add support for CSS container query scroll-state.
* Fix an issue where selector with comma would not expand correctly.
* Make fix for issue less#4313 selector list not expanding correctly more flexible.
* Add more tests for fix for issue less#4313.
* Cleanup merge issues for fix for issue less#4313.
Looks like CI may have an issue. Tests pass locally for me.
|
I re-ran CI but ran into issues. Branch passes all tests locally for me. I wouldn't expect files changed to impact CI (two test files, one source file). Would you be able to take a look? @iChenLei |
* Revise CI for missing browser issue.
* Trying to resolve CI issues with Playwright.
* Trying to resolve CI issues with Playwright.
* Trying to resolve CI issues with Playwright.
* Fix CI by pinning CI version to resolve incorrect browser binary downloads.
FYI figured out the new CI issue. Had to revise CI file to pin Playwright version to resolve browser binary mismatches. @iChenLei @matthew-dean See files changed in this PR. |
@@ -28,6 +28,7 @@ | |||
"devDependencies": { | |||
"github-changes": "^1.1.2", | |||
"lerna": "^3.22.1", | |||
"npm-run-all": "^4.1.5" | |||
"npm-run-all": "^4.1.5", | |||
"playwright": "^1.49.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"playwright": "^1.49.0" | |
"playwright": "1.49.0" |
If you are pinning playwright to 1.49.0
in the scripts, you prob want to pin playwright in the package.
^1.49.0
will accept anything up to 2.x.x
What:
PR contains a fix for issue #4313 selector list not expanding with & symbol.
Why:
In Less.js version 4.2.2, this Less:
produces the incorrect CSS:
the & symbol should now be properly expanded with the fix.
Checklist: