Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issue:4301) at-rule declarations missing #4302

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

puckowski
Copy link
Contributor

What:

Why:

User raised an issue in #4267 (comment) where they noted @media and @container are not properly nesting in some cases.

Shared at-rule function was incorrectly assuming all nodes in list were of same type, but as of Less.js 4.2.0 that is no longer true as @container query support was firmed up in that release and can be mixed with @media.

Checklist:

  • Documentation
  • Added/updated unit tests
  • Code complete

* Fixes issue less#4301. At-rule declarations may go missing or are
  incorrectly merged under certain nesting conditions.
* Added more ```@container``` tests.
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 19, 2024
@puckowski
Copy link
Contributor Author

CI seems flaky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant