Specify browser targets in minify step #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use target browsers in minify step.
A few months ago I ran into an issue, when compiling in release mode, where some css rules were wrongly merging together, resulting in broken css in firefox. I thought the issue was in lightningcss and reported it there at the time, and now it seems the issue has been fixed on that side.
However I tested with latest lightningcss and the issue persisted, so it seemed like the only way this was happening was if the targets weren't being correctly passed in the minify step and lo and behold that was indeed what was happening. I also tried only the code change without bumping lightningcss and that was not enough to generate correct css.
With both passing targets and bumping lightningcss, the css generated correctly.