Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for strictPluralKeys MessageFormat option #108

Merged
merged 2 commits into from
Jul 2, 2023

Conversation

jaideepsingh
Copy link
Contributor

Issue #102

With reference to the above issue, a default true option strictPluralKeys was added to @messageformat/core package.

This change adds support for that option.

@jaideepsingh
Copy link
Contributor Author

@lephyrus May I request a review here please? Many thanks 🙏

@lephyrus
Copy link
Owner

@jaideepsingh Thanks for the PR! Prettier is complaining about some of the formatting, and could you add the new strictPluralKeys config option to the corresponding code block in the README where all the config options and their defaults are listed? Once that's done, I'll be happy to merge and release a new version.

@jaideepsingh
Copy link
Contributor Author

@jaideepsingh Thanks for the PR! Prettier is complaining about some of the formatting, and could you add the new strictPluralKeys config option to the corresponding code block in the README where all the config options and their defaults are listed? Once that's done, I'll be happy to merge and release a new version.

@lephyrus Thank you for the feedback. I have updated the PR with your suggestions. Please take a look whenever you can.

@jaideepsingh
Copy link
Contributor Author

@lephyrus Apologies for bothering you again. Just wanted to follow up on this one if you had a chance to take a look at this yet. This update is critical for our team as it is blocking migrating our apps to Angular 15 and subsequent versions. I would greatly appreciate any time you could spare to review this. Many thanks in advance 🙏

@lephyrus lephyrus merged commit 187ab58 into lephyrus:master Jul 2, 2023
@lephyrus
Copy link
Owner

lephyrus commented Jul 2, 2023

This is now available in version 6.5.0. Thanks again for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants