Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General update and feature addition #48

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

liz3
Copy link

@liz3 liz3 commented Jan 8, 2021

This PR does quit a lot so il try to list everything i did over the last two days.

  • Updated react and react script dependencies
  • Updated all Components to work with react 16.
  • Fixed the issue that prevented content reset when exiting Webhook mode
  • Implemented others pull request changes, namely (Update discordpy.js #46 , Update Discord.Net inline field snippet #41, Add MessageEmbed code generation for Discord.js #44)
  • Changed behaviour when exiting webhook mode.
  • Implemented Invite rendering
  • Added a general way to support Webhook mode in code generation
  • Added Webhook support (Code generation) for: Discord.net, discord.py, jda, and discordjs(v12 version)
  • In Webhook mode color picker now updates ALL embeds
  • Added husky for precommit formatting
  • added npm lock file

Note: I have deployed my version to: https://liz3.github.io/embed-visualizer/, should this PR be rejected i will keep it there online.

Liz3

@Andre601
Copy link

Would like to mention, that JDA does NOT have direct webhook support. JDA itself only supports retrieval of Webhooks and their content, but not sending them (At least last time I checked it was that case)

Instead, most if not all webhook handling was moved to a separate library currated by MinnDevelopment which is simply called "Discord Webhooks" (Link)
So maybe correct this, if you're still supporting this PR that is...

@liz3
Copy link
Author

liz3 commented Nov 6, 2022

Ig this wont ever be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants