Refactor hopper training loop and model loading

[leonvanbokhorst]

Simplify the hopper training loop by removing commented out code and unnecessary print statements. Also, refactor the model loading process to handle cases where no saved model is found. This improves the readability and maintainability of the code.

Summary by Sourcery

Enhancements:

• Refactor the model loading process to handle cases where no saved model is found, improving code readability and maintainability.

[sourcery-ai]

Reviewer's Guide by Sourcery

The changes uncomment and restore the training loop functionality in the hopper.py file, which includes model loading and training phases. The code now properly handles model loading with error cases and implements the training phase loop that was previously commented out.

Sequence diagram for the hopper training loop

sequenceDiagram
    actor User
    participant Hopper as Hopper Training
    participant Model as Model Loader

    User->>Hopper: Start Training
    Hopper->>Model: Load Model
    alt Model Found
        Model-->>Hopper: Load Successful
        Hopper->>Hopper: Update global_best_reward
    else No Model Found
        Model-->>Hopper: Error
        Hopper->>Hopper: Start with Untrained Agent
    end
    Hopper->>Hopper: Train Agent
    alt Training Successful
        Hopper-->>User: Reached Solution Threshold
    else Training Unsuccessful
        Hopper->>Hopper: Continue Training
    end

Loading

File-Level Changes

Change	Details	Files
Restore and implement the training phase loop	Uncomment the phase iteration loop that runs 10 training phases Restore the training progress print statement Implement the training loop with success condition check Re-enable the early exit when solution threshold is reached	gym/hopper.py
Implement robust model loading functionality	Uncomment and enable model checkpoint loading code Add error handling for FileNotFoundError and RuntimeError cases Implement proper loading of previous best reward from checkpoint Add informative print statements for model loading status	gym/hopper.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @leonvanbokhorst - I've reviewed your changes - here's some feedback:

Overall Comments:

• The commit message doesn't accurately reflect the changes. Consider updating it to something like 'Enable hopper training loop' since the main change is uncommenting and activating the existing training code rather than refactoring it.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue (code-quality): Use named expression to simplify assignment and conditional (use-named-expression)