Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'poc_async.py' and rename files for consistency #31

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

leonvanbokhorst
Copy link
Owner

@leonvanbokhorst leonvanbokhorst commented Oct 27, 2024

Summary by Sourcery

Chores:

  • Remove the 'poc_async.py' file from the 'pocs' directory.
  • Rename files to 'nfd_' for consistency

Copy link
Contributor

sourcery-ai bot commented Oct 27, 2024

Reviewer's Guide by Sourcery

This pull request removes an unused proof of concept file (poc_async.py) from the codebase, contributing to better code organization and maintenance.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Removal of unused proof of concept file
  • Deleted unused proof of concept file for async functionality
pocs/poc_async.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @leonvanbokhorst - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The PR title suggests a rename operation, but the diff only shows a file deletion. Please clarify if this is a rename (in which case we need to see the new file location) or a removal.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@leonvanbokhorst leonvanbokhorst changed the title rename refactoring for consistency @sourcery-ai Oct 27, 2024
@sourcery-ai sourcery-ai bot changed the title @sourcery-ai Remove 'poc_async.py' from 'pocs' directory Oct 27, 2024
@leonvanbokhorst leonvanbokhorst changed the title Remove 'poc_async.py' from 'pocs' directory @sourcery-ai Oct 27, 2024
@sourcery-ai sourcery-ai bot changed the title @sourcery-ai Remove 'poc_async.py' and rename files for consistency Oct 27, 2024
@leonvanbokhorst
Copy link
Owner Author

Renamed file names to prefix 'nfd_' for consistency

@leonvanbokhorst leonvanbokhorst merged commit 1e915d8 into main Oct 27, 2024
1 check passed
@leonvanbokhorst leonvanbokhorst deleted the patch-rename branch October 27, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant