Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STATS] Send actual frequency to api server #345

Merged
merged 1 commit into from
May 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src_erl/NerlnetApp/src/Source/sourceStatem.erl
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ init({MyName, WorkersMap, NerlnetGraph, Policy, BatchSize, Frequency , Epochs, T
ets:insert(EtsRef, {sample_size, none}),
ets:insert(EtsRef, {workers_list, []}),
ets:insert(EtsRef, {csv_name, ""}), % not in use
ets:insert(EtsRef, {stats_ets, EtsStatsRef}),

{MyRouterHost,MyRouterPort} = nerl_tools:getShortPath(MyName,?MAIN_SERVER_ATOM, NerlnetGraph),
ets:insert(EtsRef, {my_router,{MyRouterHost,MyRouterPort}}),
Expand Down Expand Up @@ -402,4 +403,6 @@ transmitter(TimeInterval_ms, SourceEtsRef, SourcePid ,ClientWorkerPairs, Batches
gen_statem:cast(SourcePid,{finishedCasting,BatchesSent}),
ActualFrequency = 1/(TransmissionTimeTook_sec/BatchesSent),
?LOG_INFO("Source ~p Actual Frequency: ~p [B/Sec]",[MyName, ActualFrequency]),
StatsEtsRef = ets:lookup_element(SourceEtsRef, stats_ets, ?DATA_IDX),
stats:set_value(StatsEtsRef, actual_frequency, ActualFrequency),
ets:delete(TransmitterEts).
11 changes: 8 additions & 3 deletions src_erl/NerlnetApp/src/Stats/stats.erl
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
-export([get_bytes_sent/1, increment_bytes_sent/2]).
-export([get_bad_messages/1, increment_bad_messages/1]).
-export([get_value/2, increment_by_value/3]).
-export([set_value/3]).
-export([encode_ets_to_http_bin_str/1 , decode_http_bin_str_to_ets/1 , encode_workers_ets_to_http_bin_str/1]).
-export([update_workers_ets/4, increment_workers_ets/4 , generate_workers_stats_ets/0]).

Expand Down Expand Up @@ -63,8 +64,8 @@ decode_http_bin_str_to_ets(EncodedStr) ->
ReturnedEts.


generate_stats_ets() -> %% clients , routers , mainserver...
StatsEts = ets:new(stats_ets , [set]),
generate_stats_ets() -> %% sources, clients , routers , mainserver...
StatsEts = ets:new(stats_ets , [set, public]),
ets:insert(StatsEts, {messages_received , 0}),
ets:insert(StatsEts, {messages_sent , 0}),
ets:insert(StatsEts, {messages_dropped , 0}),
Expand All @@ -73,7 +74,8 @@ generate_stats_ets() -> %% clients , routers , mainserver...
ets:insert(StatsEts, {bad_messages , 0}),
ets:insert(StatsEts, {batches_received , 0}), % related with client only
ets:insert(StatsEts, {batches_dropped , 0}), % related with client only
ets:insert(StatsEts, {batches_sent , 0}), % related with source
ets:insert(StatsEts, {batches_sent , 0}), % related with source only
ets:insert(StatsEts, {actual_frequency, 0}), % related with source only
StatsEts.

generate_workers_stats_ets() -> %% workers..
Expand Down Expand Up @@ -107,6 +109,9 @@ increment_workers_ets(StatsEts, WorkerName, WorkerAttribute, Value) ->
ets:update_counter(WorkerStatsEts, Key, Value).

%% ---- Stats ETS Methods -----%%
set_value(StatsEts, Key, Value) ->
ets:update_element(StatsEts, Key, {?STATS_KEYVAL_VAL_IDX, Value}).

increment_by_value(StatsEts, Key, Value) ->
ets:update_counter(StatsEts, Key, Value).

Expand Down
5 changes: 4 additions & 1 deletion src_py/apiServer/NerlComDB.py
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ class SourceComDB(EntityComDB):
def __init__(self):
super().__init__()
self.batches_sent = 0
self.actual_frequency = 0

def __add__(self, other):
self.batches_sent += other.batches_sent
Expand All @@ -217,6 +218,7 @@ def update_stats(self, input_dict):
self.bytes_sent = input_dict["bytes_sent"]
self.bad_messages = input_dict["bad_messages"]
self.batches_sent = input_dict["batches_sent"]
self.actual_frequency = input_dict["actual_frequency"]

def get_as_dict(self):
return {
Expand All @@ -226,7 +228,8 @@ def get_as_dict(self):
"bytes_received": self.bytes_received,
"bytes_sent": self.bytes_sent,
"bad_messages": self.bad_messages,
"batches_sent": self.batches_sent
"batches_sent": self.batches_sent,
"actual_frequency": self.actual_frequency
}

class NerlComDB():
Expand Down
5 changes: 5 additions & 0 deletions src_py/apiServer/experiment_flow_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ def print_test(in_str : str , enable = True):
clients: {stats_train.get_communication_stats_clients()}\
routers: {stats_train.get_communication_stats_routers()}"

LOG_INFO("Actual Frequencies:")
print(f"{stats_train.get_actual_frequencies_of_sources()}")

LOG_INFO("Missed Batches training:")
#LOG_INFO(stats_train.get_missed_batches())

Expand All @@ -95,6 +98,8 @@ def print_test(in_str : str , enable = True):
clients: {stats_predict.get_communication_stats_clients()}\
routers: {stats_predict.get_communication_stats_routers()}"

LOG_INFO("Actual Frequencies:")
print(f"{stats_predict.get_actual_frequencies_of_sources()}")

missed_batches = stats_predict.get_missed_batches()
if missed_batches:
Expand Down
8 changes: 8 additions & 0 deletions src_py/apiServer/stats.py
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,14 @@ def get_communication_stats_main_server(self):
main_server_communication_stats = self.nerl_comm_db.get_main_server().get_as_dict()
return main_server_communication_stats

def get_actual_frequencies_of_sources(self):
# return dictionary of {source : {actual_freq}}
actual_frequencies_of_sources_dict = OrderedDict()
sources_dict = self.nerl_comm_db.get_sources()
for source_name, source_db_dict in sources_dict.items():
actual_frequencies_of_sources_dict[source_name] = source_db_dict.get_as_dict()["actual_frequency"]
return actual_frequencies_of_sources_dict

def get_model_performence_stats(self , confusion_matrix_worker_dict , show : bool = False , saveToFile : bool = False, printStats = False) -> dict:
"""
Returns a dictionary of {(worker, class): {Performence_Stat : VALUE}}} for each worker and class in the experiment.
Expand Down