Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StatsUpdate #307

Merged
merged 18 commits into from
Apr 25, 2024
Merged

StatsUpdate #307

merged 18 commits into from
Apr 25, 2024

Conversation

GuyPerets106
Copy link
Collaborator

Updated dependencies in src_py/requirments.txt to include seaborn library. Updated stats.py to include graphs and confusion matrices , as well as data frames return values of some functions.
Also included some json files defining the 8Device experiment and the jupyter notebook under examples/syntetic_norm/8DeviceTest

More future tasks:

  • Turn all return values of stats.py functions to be pandas DataFrame. (Easy to plot and look nice)
  • Filter confusion matrices and loss function graphs by worker: In bigger experiments the large number of workers will make the graphs look scrambled and non-informative. With large number of workers and classes the number of confusion matrices is huge. Maybe creating a function like get_conf_mat_by_worker/workers/device will be better.

@leondavi
Copy link
Owner

@GuyPerets106
Please make this PR pass CI
It already includes W2W changes so PR of W2W com should be deprecated.


if plot:
sns.lineplot(data=df)
plt.xlabel('Batch Num.')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GuyPerets106
interesting that it allows you to mix sns and plt

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seaborn is based on matplotlib , it just add to the visuals and capabilities 😄

@leondavi leondavi merged commit baa711a into master Apr 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants