Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added is_disc_cache_active/0 #4

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

windkit
Copy link

@windkit windkit commented Oct 26, 2017

No description provided.

@mocchira
Copy link
Member

@windkit LGTM. just in case, please bench before/after applying this patch and using it on leo_gateway to confirm whether no performance degradation happens.

if non-negligible performance degradation happened then please consider using Props variable at https://github.com/leo-project/leofs/blob/develop/apps/leo_gateway/src/leo_gateway_s3_api.erl#L768 which contains enough information to judge if disk cache is active and passing those information through request_params that enables any http handler defined at leo_gateway_http_commons to refer those and no need to access ets at all.

@mocchira
Copy link
Member

@windkit also please add .travis.yml for this repo.

@windkit
Copy link
Author

windkit commented Nov 2, 2017

@mocchira thanks for the comment, and now the leo-project/leofs#909 check the disk cache in http_options

@mocchira
Copy link
Member

mocchira commented Nov 2, 2017

@windkit OK. I will check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants