-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Test Codes #54
base: main
Are you sure you want to change the base?
Add Test Codes #54
Conversation
I'm a bit concerned about adding minif2f to the unit testing pipeline. Building mathlib takes a while. If it is just mathlib we could Can you set it up so that instead of using an example skeleton project with mathlib as a dependency, the minif2f tests directly run with project root pointing to Mathlib? This way we can leverage |
You might approve this PR to run the actions, or check it here https://github.com/Lean-zh/PyPantograph/pull/2/checks |
@pytest.mark.advance | ||
def test_load_theorem(minif2f_server: Server, minif2f_test: DataFrame, minif2f_valid: DataFrame): | ||
"""Comprehensive test for loading multiple theorems. | ||
use pytest -m "not advance" to skip this test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use pytest -m "not advance"
instead to skip some tests if it takes too long.
Add Test Codes
Hi @lenianiva, could you review the test setup in this PR?
Changes Made
The other PR's tests passed successfully.Some of the statements need fixing, check the LSP here as commented before.Added pytest framework, migrate unitests from
server.py
totest_server.py
You can run the test suite with:
Next Steps
Add GitHub workflow for automated testingpytest tests -m error
For error cases, we could fix in a new PR to simplify the review process?
Please let me know if you'd like any further adjustments.