Skip to content

fix compilation error with literal newline (#5) #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aspiers
Copy link

@aspiers aspiers commented Nov 6, 2022

Literal newlines need to be inside backticks not double quotes.

Fixes #5.

@kucharskim kucharskim mentioned this pull request May 25, 2023
@jbwells
Copy link

jbwells commented Jul 7, 2024

see my comment on issue #5. this is not quite the right fix. (nonetheless, the real mystery is why no fix at all has been added to the master branch in the last 23 months. there seem to be two people with commit access to this repo, but a showstopper bug hasn't been fixed. has active development moved to some other fork?)

Literal newlines need to be inside backticks not double quotes.

Fixes lemnos#5.
@aspiers aspiers force-pushed the fix-literal-newline branch from 62db4c2 to fedf227 Compare September 1, 2024 11:53
@aspiers
Copy link
Author

aspiers commented Sep 1, 2024

Good catch; updated the PR accordingly.

I guess the maintainers probably lost interest and/or don't use this tool any more.

@aspiers
Copy link
Author

aspiers commented Sep 1, 2024

I've also merged into the master branch of my fork in case anyone wants a working version:

https://github.com/aspiers/chrome-session-dump/tree/master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation error
2 participants