-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: more multiple-cursor commands #1517
Draft
Book-reader
wants to merge
15
commits into
lem-project:main
Choose a base branch
from
Book-reader:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+105
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds more commands to
multiple-cursors.lisp
that emulates themark-next/previous-like-this
functionality from multiple-cursors.el as well as adding aadd-cursors-to-previous-line
command to match theadd-cursors-to-next-line
command.example.mp4.webm
things I have not done yet:
mark-previous-like-this
not working at allmark-previous-like-this
skipping every second match when cursor is to the left of the mark (buffer-point < buffer-mark)mark-next-like-this
always placing fake cursor on the right side of the mark, even when the real cursor is on the left sidemark-previous-like-this
andmark-next-like-this
mark-next/previous-like-this
runadd-cursors-to-next/previous-line
when nothing is marked (to matchmultiple-cursors.el
)mark-next-like-this
not working with multiple linesissues with multiple cursors out of scope of this PR:
multiple-cursors.el
, the fake cursors stay when usingkeyboard-escape-quit
and are only cleared withkeyboard-quit
. this allows callingkeyboard-escape-quit
to unmark the current buffer without removing all the fake cursors. in lem there is onlykeyboard-quit
which both unmarks the buffer and removes all the cursors.I am not very good with lisp so please tell me if there are any problems with my code.
I have moved
multiple-cursors.lisp
toextensions/
becauseadd-cursors-to-next-like-this
uses isearch and I could not figure out how to import the needed functions and commands when it was in lem-core.