fix empty-string LEGEND_METADATA env var #80
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is quite common to use
ENV_VAR= command --args ...
for this to unset an env var for a commanduntil now (in stable versions), pylegendmeta did try to use the current directory as a metadata repo.
with the changes from #75. this might have bad consequences on unrelated git repos, as now legendmeta does try to check out tags in the git repo.
The solution implemented here treats an empty path as if
None
had been passed. The other option would be to throw an exception if an empty path is provided.