Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sipm calibration routines #88

Merged
merged 12 commits into from
Nov 11, 2024
Merged

Sipm calibration routines #88

merged 12 commits into from
Nov 11, 2024

Conversation

theHenks
Copy link
Collaborator

This PR includes a SiPM calibration routine fit based on the GaussianMixtures.jl package.

  • It fits a certain PE range with the mixture model and determines the PE positions including uncertainty handling based on ForwardDiff
  • The sipm_simple_calibration function is adapted to have better output results
  • Plot recipes for all outputs
    The recipe can be controlled with the following kwargs:
  • xerrscaling: scale all errors by a factor
  • show_residuals: show residual panel
  • show_peaks: show peak positions in plot
  • show_components: show all mixtures components
image

@theHenks theHenks requested a review from fhagemann November 11, 2024 21:45
@theHenks theHenks added the enhancement New feature or request label Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 1.65975% with 237 lines in your changes missing coverage. Please review.

Please upload report for BASE (dev@2575f47). Learn more about missing BASE report.
Report is 30 commits behind head on dev.

Files with missing lines Patch % Lines
ext/LegendSpecFitsRecipesBaseExt.jl 0.00% 171 Missing ⚠️
src/sipmfit.jl 0.00% 48 Missing ⚠️
src/sipm_simple_calibration.jl 0.00% 17 Missing ⚠️
src/fit_calibration.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev      #88   +/-   ##
======================================
  Coverage       ?   20.49%           
======================================
  Files          ?       35           
  Lines          ?     3177           
  Branches       ?        0           
======================================
  Hits           ?      651           
  Misses         ?     2526           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theHenks theHenks merged commit 143524e into dev Nov 11, 2024
10 checks passed
@theHenks theHenks deleted the sipm-cal branch November 11, 2024 21:53
@fhagemann
Copy link
Contributor

fhagemann commented Nov 11, 2024

I was requested as reviewer.. should I still look through this or not?
Tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants