Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple fit Optimization.jl #79

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Simple fit Optimization.jl #79

merged 4 commits into from
Oct 11, 2024

Conversation

theHenks
Copy link
Collaborator

  • Use Optimization.jl with LBFGS for all single gaussian fits
  • Added tests for single fits

@theHenks theHenks added bug Something isn't working enhancement New feature or request labels Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes missing coverage. Please review.

Project coverage is 22.14%. Comparing base (e302032) to head (41b2b89).
Report is 9 commits behind head on dev.

Files with missing lines Patch % Lines
src/singlefit.jl 80.76% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #79      +/-   ##
==========================================
+ Coverage   14.85%   22.14%   +7.28%     
==========================================
  Files          32       33       +1     
  Lines        2841     2940      +99     
==========================================
+ Hits          422      651     +229     
+ Misses       2419     2289     -130     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theHenks theHenks merged commit 4c6ceba into dev Oct 11, 2024
10 checks passed
@theHenks theHenks deleted the simple-fit branch October 11, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant