Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fixes in MLE fits #73

Merged
merged 48 commits into from
Oct 6, 2024

Fix imports

74bcf77
Select commit
Loading
Failed to load commit list.
Merged

Bug Fixes in MLE fits #73

Fix imports
74bcf77
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 6, 2024 in 0s

15.01% (-0.45%) compared to 79f52b7, passed because coverage increased by 1.28% when compared to adjusted base (13.73%)

View this Pull Request on Codecov

15.01% (-0.45%) compared to 79f52b7, passed because coverage increased by 1.28% when compared to adjusted base (13.73%)

Details

Codecov Report

Attention: Patch coverage is 24.69512% with 247 lines in your changes missing coverage. Please review.

Project coverage is 15.01%. Comparing base (79f52b7) to head (74bcf77).
Report is 24 commits behind head on dev.

Files with missing lines Patch % Lines
src/peakstats.jl 26.22% 45 Missing ⚠️
src/fit_calibration.jl 0.00% 35 Missing ⚠️
src/singlefit.jl 0.00% 34 Missing ⚠️
src/aoefit_combined.jl 0.00% 28 Missing ⚠️
src/ctc.jl 0.00% 27 Missing ⚠️
ext/LegendSpecFitsRecipesBaseExt.jl 0.00% 26 Missing ⚠️
src/fit_fwhm.jl 0.00% 24 Missing ⚠️
src/aoe_fit_calibration.jl 0.00% 8 Missing ⚠️
src/lqfit.jl 0.00% 8 Missing ⚠️
src/aoefit.jl 0.00% 5 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #73      +/-   ##
==========================================
- Coverage   15.46%   15.01%   -0.45%     
==========================================
  Files          32       33       +1     
  Lines        2489     2670     +181     
==========================================
+ Hits          385      401      +16     
- Misses       2104     2269     +165     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.