Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add A/E ctc plot recipe #121

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Add A/E ctc plot recipe #121

merged 2 commits into from
Feb 26, 2025

Conversation

fhagemann
Copy link
Contributor

Closes #97.

p = plot(report_aoe_ctc)
title!(p, get_plottitle(filekey_ch, part, det, "A/E CT Correction"; additiional_type=string(aoe_type)), subplot = 1)

image

@fhagemann fhagemann requested a review from theHenks February 25, 2025 09:07
@fhagemann fhagemann self-assigned this Feb 25, 2025
@fhagemann fhagemann requested a review from verenaaur February 25, 2025 09:08
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 59 lines in your changes missing coverage. Please review.

Project coverage is 28.71%. Comparing base (10e8e19) to head (c463d03).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
ext/LegendSpecFitsRecipesBaseExt.jl 0.00% 57 Missing ⚠️
src/aoe_ctc.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   29.24%   28.71%   -0.54%     
==========================================
  Files          37       37              
  Lines        3447     3504      +57     
==========================================
- Hits         1008     1006       -2     
- Misses       2439     2498      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fhagemann
Copy link
Contributor Author

And again, a little Makie sneak peek:
image

@fhagemann fhagemann changed the title Aoe ctc plot recipe A/E ctc plot recipe Feb 25, 2025
@fhagemann fhagemann changed the title A/E ctc plot recipe Add A/E ctc plot recipe Feb 25, 2025
@fhagemann fhagemann added the enhancement New feature or request label Feb 25, 2025
Copy link
Collaborator

@theHenks theHenks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks!

@theHenks
Copy link
Collaborator

Wow, the plots look amazing! Thanks @fhagemann 😍

@fhagemann fhagemann added the bug Something isn't working label Feb 26, 2025
@fhagemann
Copy link
Contributor Author

@theHenks feel free to merge at your earliest convenience

@theHenks theHenks merged commit 4179a69 into main Feb 26, 2025
11 of 13 checks passed
@theHenks theHenks deleted the aoe_ctc_plot_recipe branch February 26, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Plot recipe for A/E ctc
2 participants