Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch sipm_simple_calibration #120

Merged
merged 13 commits into from
Feb 26, 2025
Merged

Patch sipm_simple_calibration #120

merged 13 commits into from
Feb 26, 2025

Conversation

theHenks
Copy link
Collaborator

Updated sipm_simple_calibration for more stability in simple calibration routine.

  • Bug Fix peakfinder_σ to also scale within each bin_width step
  • Bug Fix n_fwhm_noise_cut for the 0.0 case
  • Use SavitzkyGolay smoothing prior to peak search routine to smoothen PE distribution and enhance accuracy
  • Inlcude failsafe routine by simple maximum detection based on smoothed histograms

@theHenks theHenks requested a review from fhagemann February 25, 2025 04:16
@theHenks theHenks self-assigned this Feb 25, 2025
@theHenks theHenks added bug Something isn't working enhancement New feature or request labels Feb 25, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 29.02%. Comparing base (113fc5f) to head (8c62c6a).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
src/sipm_simple_calibration.jl 0.00% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
- Coverage   29.88%   29.02%   -0.87%     
==========================================
  Files          37       37              
  Lines        3366     3466     +100     
==========================================
  Hits         1006     1006              
- Misses       2360     2460     +100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@fhagemann fhagemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some code duplication at the end of this function (the fallback method).
This is fine for me. If you want to remove it, you could export the duplicate code into a separate function that takes bin_width_scale as input and call it in the loop as well as in the fallback case.

@theHenks theHenks merged commit 33f3e3d into main Feb 26, 2025
11 of 13 checks passed
@theHenks theHenks deleted the patch_sipm-simple-peakfinder branch February 26, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants