Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix SiPM Simple Calibration + Optimization #112

Merged
merged 13 commits into from
Feb 3, 2025
Merged

Bug Fix SiPM Simple Calibration + Optimization #112

merged 13 commits into from
Feb 3, 2025

Conversation

theHenks
Copy link
Collaborator

@theHenks theHenks commented Feb 3, 2025

  • Updated sipm_simple_calibration routines to be more robust for PE spectral detection by cutting out a possible noise peak followed by the use of determine_calibration_constant_trough_peak_ratios
  • Included SiPM optimization routines by sweeping through different filter length and the determination of resolution and gain which is used as objective.
  • Minor Bug Fixes

@theHenks theHenks requested a review from fhagemann February 3, 2025 10:51
@theHenks theHenks added bug Something isn't working enhancement New feature or request labels Feb 3, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 3, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 112 lines in your changes missing coverage. Please review.

Project coverage is 20.85%. Comparing base (31ab269) to head (2346c99).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/sipm_filter_optimization.jl 0.00% 51 Missing ⚠️
src/sipm_simple_calibration.jl 0.00% 32 Missing ⚠️
ext/LegendSpecFitsRecipesBaseExt.jl 0.00% 27 Missing ⚠️
src/sipmfit.jl 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
- Coverage   21.28%   20.85%   -0.43%     
==========================================
  Files          36       37       +1     
  Lines        3312     3380      +68     
==========================================
  Hits          705      705              
- Misses       2607     2675      +68

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fhagemann
Copy link
Contributor

This commit history needs some fixing.. There are some commits that are already on main in here..
Let me work on this.

@fhagemann
Copy link
Contributor

The force push fixed the commit history ;)

fhagemann
fhagemann requested changes Feb 3, 2025
View reviewed changes
@theHenks
Copy link
Collaborator Author

theHenks commented Feb 3, 2025

An example of the recipe plot for the filter optimization:
l200-p03-r000-phy-S023-wl_sweep_sg

@fhagemann
Copy link
Contributor

The Downgrade tests seem to freeze because of [email protected]
@theHenks: could you bump the version to 0.3.12?

@theHenks
Copy link
Collaborator Author

theHenks commented Feb 3, 2025

The Downgrade tests seem to freeze because of [email protected] @theHenks: could you bump the version to 0.3.12?

Is this not already done on main?

@fhagemann fhagemann merged commit 74f700a into main Feb 3, 2025
11 of 13 checks passed
@fhagemann fhagemann deleted the patch_sipm-simple branch February 3, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhagemann fhagemann fhagemann approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theHenks @fhagemann