-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch sipm_simple_calibration
#120
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
==========================================
- Coverage 29.88% 29.02% -0.87%
==========================================
Files 37 37
Lines 3366 3466 +100
==========================================
Hits 1006 1006
- Misses 2360 2460 +100 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is some code duplication at the end of this function (the fallback method).
This is fine for me. If you want to remove it, you could export the duplicate code into a separate function that takes bin_width_scale
as input and call it in the loop as well as in the fallback case.
Updated
sipm_simple_calibration
for more stability in simple calibration routine.peakfinder_σ
to also scale within eachbin_width
stepn_fwhm_noise_cut
for the0.0
caseSavitzkyGolay
smoothing prior to peak search routine to smoothenPE
distribution and enhance accuracy