Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade typescript from 4.2.4 to 4.4.3 #503

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

guusdk
Copy link
Contributor

@guusdk guusdk commented Jan 31, 2024

This intends to prevent the following compilation error:

$ npm run compile

> [email protected] compile
> tsc -p .

node_modules/@types/babel__traverse/index.d.ts:326:10 - error TS1023: An index signature parameter type must be either 'string' or 'number'.

326         [k: `${string}|${string}`]: VisitNode<S, Node>;
             ~


Found 1 error.

Inspiration for this change was taken from DefinitelyTyped/DefinitelyTyped#65766

@legastero please be aware that I'm out of my depth here. I'm suggesting this change without truly understanding the problem that it apparently fixes. Please review carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant