Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build errors #4

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix build errors #4

wants to merge 4 commits into from

Conversation

freddycansic
Copy link

The nightly feature proc_macro_span_shrink no longer exists but is being referenced by an old Cargo.lock file, resulting in a build error

error[E0635]: unknown feature `proc_macro_span_shrink`
  --> /home/freddy/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.51/src/lib.rs:92:30
   |
92 |     feature(proc_macro_span, proc_macro_span_shrink)
   |                              ^^^^^^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0635`.
error: could not compile `proc-macro2` (lib) due to 1 previous error

Deleting Cargo.lock fixes this.
Added Cargo.lock to .gitignore for future commits.

@mautamu
Copy link
Member

mautamu commented Jan 30, 2024

Hello, fellow adventurer @freddycansic!

Thank you for submitting this PR; I have resolved build errors (feel free to roll up if you would like) and requested review by @blackdragon2447 since Clippy suggested changing WindowRules to Rules which may be a breaking change if this is being used downstream.

@@ -50,7 +50,7 @@ pub enum Window {
Home,
Workspaces { index: usize, empty: bool },
Tags { index: usize, empty: bool },
WindowRules { index: usize, empty: bool },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer this stays as WindowRules instead Rules, because even though it is Window::WindowRules, both windows in that are completely disconnected, the window enum is referring to windows in the tui, while the WindowRules refer to LeftWM window rules.

// Layout::Monocle,
// Layout::RightWiderLeftStack,
// Layout::LeftWiderRightStack,
//];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly remove the commented code fully if we're sure that we're not going to use it again.

@@ -1,4 +1,5 @@
/target
Cargo.lock
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer if Cargo.lock stays on git, just to make sure builds stay consistent.

@blackdragon2447
Copy link
Collaborator

Sorry it took me so long to for the review, motivation is kinda all over the place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants