Fix for trailing CR character with omni completion on Windows. #152
Conversation
This issue manifests on Windows OS, because CRLF is used here for end of line and systemlist() function splits lines on LF cahracter. system() function takes care of OS specific end of line chars.
There was a problem hiding this comment.
Can we please split these two commits into two PRs since the topic is completely different. The balance and register command stuff can be based on your branch with the split fixes so we don't have to do that merge work twice. I'll just merge it afterwards, but we have a test issue and it would be a lot easier to review and figure out the regression with only one fix going on at a time.
|
Of course. This was not my intention. I made a mistake and commited my experiments with balance and register commands to this branch. Now I am not sure how to proceed. Should I close this PR and create a new one containing only the split fixes? Or adding new commit to this PR that reverts changes in last commit (balance and register commands) is better approach? Thanks. |
|
No need to close this, just shuffle things around. Untested from memory, but you'll want something like this: # Save your current state in a new branch
git branch extra-commands
# Reset your current branch to the previous commit
git reset --hard HEAD^
# Push the new (now reset) state of this branch back here
git push --force
# Switch to your other branch to keep working on that
git switch extra-commands
# Push the new branch and open a new PR for it
git push |
|
Great, thanks. I will do it next week, when I'm back at home. |
Fixes #151.