Skip to content

Commit

Permalink
tools: util-linux: disable NLS again
Browse files Browse the repository at this point in the history
It seems that util-linux enables NLS support by default, this worked for
almost all platforms except for macOS on x86 where it seems that libintl is
preinstalled and thus it will link against gettext with libintl for NLS
support.

This would the later cause e2fsprogs and mtd-utils to fail:
Undefined symbols for architecture x86_64:
  "_libintl_gettext", referenced from:
      _random_tell_source in libuuid.a[13](libuuid_la-randutils.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Issue appeared after I converted the tool to use --disable-all-programs and
accidentally dropped the --disable-nls from the args.

Fixes: 54115ec ("tools: util-linux: use --disable-all-programs")
Link: openwrt/openwrt#15909
Signed-off-by: Robert Marko <[email protected]>
  • Loading branch information
robimarko committed Jul 9, 2024
1 parent 2bae9d0 commit f8ccf8a
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions tools/util-linux/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ include $(INCLUDE_DIR)/host-build.mk
HOST_CONFIGURE_ARGS += \
--with-pic \
--disable-shared \
--disable-nls \
--disable-all-programs \
--enable-hexdump \
--enable-libuuid \
Expand Down

0 comments on commit f8ccf8a

Please sign in to comment.