Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use DS for RichText attributes #586

Merged
merged 4 commits into from
Oct 15, 2024
Merged

feat: use DS for RichText attributes #586

merged 4 commits into from
Oct 15, 2024

Conversation

evoiron
Copy link
Collaborator

@evoiron evoiron commented Oct 10, 2024 •
edited
Loading

Checklist

Definition Of Review

  • Own code review done (add notes for others)

  • Write message in teams channel

     <Title>

*️⃣ Impacted projects : Core - DataStudio - Admin - @leav/ui - @leav/utils - ...

📖 Ticket: https://aristid.atlassian.net/browse/<JIRA_TICKET_IDENTIFIER>

🧑‍💻 PR: <link to PR/MR>

ℹ Info: <brief explanation - context - how to test>

Definition Of Mergeable

  • 2 approves
  • 1 functional review - US has been tested
  • Every comment is handled - blocking ones have been resolved by reviewer
  • Design OK
  • Can be tested by POs
  • PR was introduced during daily meeting

evoiron
evoiron commented Oct 10, 2024
View reviewed changes
Copy link
Collaborator Author

@evoiron evoiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est un peu tricky à tester

@TdyP
Copy link
Contributor

TdyP commented Oct 11, 2024

Quand on a saisi une valeur, au blur le redimensionnement est saccadé, c'est pas très joli. Quand il n'y a pas de valeur c'est bien fluide.

A voir si c'est compliqué à corriger ou pas.

Kazam_screencast_00031.webm

@evoiron evoiron merged commit 0ea9d8e into develop Oct 15, 2024
23 of 24 checks passed
@evoiron evoiron deleted the feature/xStream-848_RichTextAttribute branch October 15, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Delmotte-Vincent Delmotte-Vincent Delmotte-Vincent left review comments

@renaudAmsellem renaudAmsellem renaudAmsellem approved these changes

@TdyP TdyP TdyP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evoiron @TdyP @renaudAmsellem @Delmotte-Vincent