Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve getInitials function with more case #303

Merged
merged 4 commits into from
Aug 23, 2023
Merged

improve getInitials function with more case #303

merged 4 commits into from
Aug 23, 2023

Conversation

Kekelgrs
Copy link
Collaborator

No description provided.

@Kekelgrs Kekelgrs requested a review from TdyP August 22, 2023 12:56
TdyP
TdyP requested changes Aug 22, 2023
View reviewed changes
libs/utils/src/utils.ts Outdated Show resolved Hide resolved
libs/utils/src/utils.ts Outdated Show resolved Hide resolved
libs/utils/src/utils.ts Show resolved Hide resolved
@Kekelgrs Kekelgrs requested a review from TdyP August 22, 2023 14:07
TdyP
TdyP requested changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@TdyP TdyP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La lib @leav/utils a besoin d'être buildée pour que les modifs soient prises en compte coté front.
Il faut lancer la commande yarn workspace @leav/utils build et push les fichiers buildés

@Kekelgrs Kekelgrs requested a review from TdyP August 23, 2023 07:39
@TdyP TdyP merged commit 2dc206e into master Aug 23, 2023
7 checks passed
@TdyP TdyP deleted the XSTREAM-91_Improve_function_getInitials branch August 23, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TdyP TdyP TdyP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kekelgrs @TdyP